Feature/edit task screen #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattCMcCoy
reviewed
Mar 28, 2024
Comment on lines
+52
to
+70
| <View style={{ flex: 1, position: 'relative' }}> | ||
| <View style={{ position: 'absolute', top: '10%', left: 5, right: 5 }}> | ||
| <PopupModal isVisible={modalVisible} setVisible={setModalVisible}> | ||
| <ActivityIndicator size="large" /> | ||
| <Text>Adding Task...</Text> | ||
| </PopupModal> | ||
| <Text | ||
| style={{ | ||
| color: 'black', | ||
| fontSize: 24, | ||
| fontWeight: 'bold', | ||
| fontFamily: 'Inter' | ||
| }} | ||
| > | ||
| Task Details | ||
| </Text> | ||
|
|
||
| <View | ||
| style={{ |
There was a problem hiding this comment.
Any chance all of this style stuff can quickly be turned into tailwind?
There was a problem hiding this comment.
See most recent commit (literally just fed it to GPT). Can you check out the mutations? Anything u see that needs changes there?
MattCMcCoy
reviewed
Mar 28, 2024
Comment on lines
+101
to
+137
| export const addNewTaskMutation = () => { | ||
| const queryClient = useQueryClient(); | ||
|
|
||
| const { mutate: addTaskMutation } = useMutation({ | ||
| mutationFn: (newTask: Task) => addNewTask(newTask), | ||
| onSuccess: () => { | ||
| queryClient.invalidateQueries('filteredTaskList'); | ||
| }, | ||
| onError: (err) => { | ||
| console.error('ERROR: Failed to Add Task. Code:', err); | ||
| } | ||
| }); | ||
|
|
||
| return addTaskMutation; | ||
| }; | ||
|
|
||
| export const editTaskMutation = () => { | ||
| const queryClient = useQueryClient(); | ||
|
|
||
| const { mutate: editTaskMutation } = useMutation({ | ||
| mutationFn: ({ | ||
| taskId, | ||
| updatedTask | ||
| }: { | ||
| taskId: string; | ||
| updatedTask: Task; | ||
| }) => editTask(taskId, updatedTask), | ||
| onSuccess: () => { | ||
| queryClient.invalidateQueries('filteredTaskList'); | ||
| }, | ||
| onError: (err) => { | ||
| console.error('ERROR: Failed to Edit Task. Code:', err); | ||
| } | ||
| }); | ||
|
|
||
| return editTaskMutation; | ||
| }; |
There was a problem hiding this comment.
Optimistic updates maybe?
MattCMcCoy
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to Ticket
Added mutations for new tasks and updating tasks. Also added bones of add new task details screen (currently disconnected)
How Has This Been Tested?
No unit tests, but basically copies structure from medication mutations.
Checklist